Review Request: Proper password caching when opening remote directories in KFileDialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103226/#review8619
-----------------------------------------------------------



kdeui/jobs/kdialogjobuidelegate.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7280>

    Can't see the point in going up to the mainwindow here.
    
    In scheduler.cpp yes, but in the delegate?



kfile/kdiroperator.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7281>

    If the scheduler already goes up to the window, why not just use "this" in all the method calls here?
    
    this is a child of parent which is in parent->window, so the loop will find the window just fine, and this removes the need for another member variable here.



kfile/kdirselectdialog.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7282>

    Same here, "this" will do just fine.



kfile/kfilewidget.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7283>

    And here too, "this" is a child of "parent" anyway.



kfile/knewfilemenu.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7284>

    This function is now unused, please remove it.



kio/kio/scheduler.cpp
<http://git.reviewboard.kde.org/r/103226/#comment7285>

    add comment to explain why we don't use  setWindow


- David Faure


On Nov. 29, 2011, 4:09 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103226/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2011, 4:09 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch fixes the scenario outlined in bug# 179663 by making the best effort to identify and use the top most window when invoking KIO functions. That way any password information supplied by the user is cached, even if the user did not check the "Remember password" checkbox, for the duration of the application instead of just the lifetime of the file dialog. 
> 
> Right now almost all KFileDialog's KIO access does not set the widget parameter. If a site then requires authentication, no window-id information will be passed to it. That in turn results in the user supplied password being cached for only a very very short duration, ~10 secs. Afterwards, the password is removed and the user is inevitably re-prompted to supply the same credentials again.
> 
> 
> This addresses bug 179663.
>     http://bugs.kde.org/show_bug.cgi?id=179663
> 
> 
> Diffs
> -----
> 
>   kdeui/jobs/kdialogjobuidelegate.cpp fe48f87 
>   kfile/kdiroperator.cpp 4c93ac9 
>   kfile/kdirselectdialog.cpp 0212e58 
>   kfile/kfilewidget.cpp 09b86d4 
>   kfile/knewfilemenu.cpp ac54041 
>   kio/kio/scheduler.cpp b4e95a5 
> 
> Diff: http://git.reviewboard.kde.org/r/103226/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with the scenario outlined in the afforementioned bug report using a publicly available demo webdav server, webdav://demo.sabredav.org.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111130/3ce955f6/attachment.htm>