Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

[Jaime Torres Amate]

> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote:
> > This fix causes a nasty regression which causes the plugin list in KRunner and other apps to be nearly unusable when compiled with gcc. Please adjust the KPluginSelector component of this fix as it must be causing a behaviour change.

Could you explain more about the problems you've noticed or fill a bug report? 
Do I have some time to try to fix the problem you've found in KRunner, instead of reverting the code to a wrong status (as not intended by the developer) again?


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103165/#review8503
-----------------------------------------------------------


On Nov. 17, 2011, 2:37 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103165/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 2:37 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Trivial c++ fixes for some warnings of clang++ (2.99.9999)
> memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
> remove double parenthesis
> change false to 0 as pointer parameter
> use parenthesis to clarify preference between ? and +
> 
> 
> Diffs
> -----
> 
>   kdecore/sycoca/kmemfile.cpp a466bde 
>   kdeui/fonts/kfontchooser.cpp 541f7db 
>   kdeui/tests/ktabwidgettest.cpp fdc3161 
>   kross/modules/form.cpp 5e260c1 
>   kutils/kemoticons/kemoticonstheme.cpp c145741 
>   kutils/kpluginselector.cpp 0a39fcc 
> 
> Diff: http://git.reviewboard.kde.org/r/103165/diff/diff
> 
> 
> Testing
> -------
> 
> Still compiles with g++
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111127/7b3afdee/attachment.htm>