Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

Aaron J. Seigo aseigo at
Tue Nov 22 14:44:28 GMT 2011

On Tuesday, November 22, 2011 13:27:53 Thomas =?ISO-8859-1?Q?L=FCbking?= 
> Given a simple mutex and a qWarning() -if hit- would not only have told
> people but also prevented crashes by implementation rather than by
> convention, I feel required to mention that this change of
> implications -as done- seems a rather bold move which certainly caused
> some stir and -at least on my side- worries about what actually *is*
> the 4.8 qDeleteAll() problem (the reason why I clicked at this RR in
> the first place)

i agree 100%. while i understand the change, a heads-up would have been nice. 
code on debug builds that caught this at runtime would have been saintly.

changes like this one and to QUrl are likely to impact Qt's reputation as no 
one will care very much beyond "my app now crashes" or "it doesn't work as it 
did" when all they do is upgrade Qt.

it also reinforces the, obviously correct, common wisdom" that upgrading Qt 
blindly is simply not safe -> you have to test carefully. whether Qt devs care 
about that or not, it's how it is :)

i truly hope that the optimization was very much worth it in this case. 
hopefully it wasn't another of those "we shaved off 5ms that nobody anywhere 
will ever actually notice" optimizations we've seen from time to time in Qt. 
again, communication on these kinds of changes would be helpful in letting 
those using Qt to decide how to feel about these things. :)

Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list