Review Request: Fix crash in KonqView

[Ruurd Pels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103176/#review8281
-----------------------------------------------------------

Ship it!


OK ship it although it might mask off deeper troubles.


konqueror/src/konqview.h
<http://git.reviewboard.kde.org/r/103176/#comment7071>

    OK I can agree with returning an empty list if m_service == null however I also think we need to come up with reasons WHY m_service == null before serviceTypes() is called. 
    
    From the original code it looks like m_service should always be initialized beforehand, so why is it that that did not happen for that particular website. Maybe an errormessage is in order?


- Ruurd Pels


On Nov. 17, 2011, 8:33 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103176/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 8:33 p.m.)
> 
> 
> Review request for KDE Base Apps and David Faure.
> 
> 
> Description
> -------
> 
> Though I cannot reproduce the bug given above, the backtrace attached to the report seems to show a NULL object is being accessed. This patch is intended to prevent such scenarios and in the process fix bugs like the one reported in bug# 285844.
> 
> 
> This addresses bug 285844.
>     http://bugs.kde.org/show_bug.cgi?id=285844
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqrun.cpp 9e9310c 
>   konqueror/src/konqview.h 45c5bde 
> 
> Diff: http://git.reviewboard.kde.org/r/103176/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111117/2e5f021f/attachment.htm>