Review Request: trivial fixes for some warnings of clang++ (2.99.9999)
Commit Hook
null at kde.org
Thu Nov 17 15:29:15 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103165/#review8272
-----------------------------------------------------------
This review has been submitted with commit e91e5fed6b1aad365e12e919f430c3e8147552d3 by Jaime Torres to branch KDE/4.7.
- Commit Hook
On Nov. 17, 2011, 2:37 p.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103165/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2011, 2:37 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Trivial c++ fixes for some warnings of clang++ (2.99.9999)
> memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
> remove double parenthesis
> change false to 0 as pointer parameter
> use parenthesis to clarify preference between ? and +
>
>
> Diffs
> -----
>
> kdecore/sycoca/kmemfile.cpp a466bde
> kdeui/fonts/kfontchooser.cpp 541f7db
> kdeui/tests/ktabwidgettest.cpp fdc3161
> kross/modules/form.cpp 5e260c1
> kutils/kemoticons/kemoticonstheme.cpp c145741
> kutils/kpluginselector.cpp 0a39fcc
>
> Diff: http://git.reviewboard.kde.org/r/103165/diff/diff
>
>
> Testing
> -------
>
> Still compiles with g++
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111117/2855ebd4/attachment.htm>
More information about the kde-core-devel
mailing list