Review Request: trivial fixes for some warnings of clang++ (2.99.9999)
Jaime Torres Amate
jtamate at gmail.com
Thu Nov 17 14:37:48 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103165/
-----------------------------------------------------------
(Updated Nov. 17, 2011, 2:37 p.m.)
Review request for kdelibs.
Changes
-------
Changed the parenthesis. Probably clang has the bug, it tells that + has preference over ?. Now, no problem.
Description
-------
Trivial c++ fixes for some warnings of clang++ (2.99.9999)
memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
remove double parenthesis
change false to 0 as pointer parameter
use parenthesis to clarify preference between ? and +
Diffs (updated)
-----
kdecore/sycoca/kmemfile.cpp a466bde
kdeui/fonts/kfontchooser.cpp 541f7db
kdeui/tests/ktabwidgettest.cpp fdc3161
kross/modules/form.cpp 5e260c1
kutils/kemoticons/kemoticonstheme.cpp c145741
kutils/kpluginselector.cpp 0a39fcc
Diff: http://git.reviewboard.kde.org/r/103165/diff/diff
Testing
-------
Still compiles with g++
Thanks,
Jaime Torres Amate
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111117/f0dbae6e/attachment.htm>
More information about the kde-core-devel
mailing list