Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

Jaime Torres Amate jtamate at
Thu Nov 17 14:37:48 GMT 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 17, 2011, 2:37 p.m.)

Review request for kdelibs.


Changed the parenthesis. Probably clang has the bug, it tells that + has preference over ?. Now, no problem.


Trivial c++ fixes for some warnings of clang++ (2.99.9999)
memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
remove double parenthesis
change false to 0 as pointer parameter
use parenthesis to clarify preference between ? and +

Diffs (updated)

  kdecore/sycoca/kmemfile.cpp a466bde 
  kdeui/fonts/kfontchooser.cpp 541f7db 
  kdeui/tests/ktabwidgettest.cpp fdc3161 
  kross/modules/form.cpp 5e260c1 
  kutils/kemoticons/kemoticonstheme.cpp c145741 
  kutils/kpluginselector.cpp 0a39fcc 



Still compiles with g++


Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list