Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

[Jaime Torres Amate]

> On Nov. 17, 2011, 12:59 p.m., David Faure wrote:
> > Looks good except for one item.

which item?


- Jaime Torres


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103165/#review8262
-----------------------------------------------------------


On Nov. 17, 2011, 11:41 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103165/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 11:41 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Trivial c++ fixes for some warnings of clang++ (2.99.9999)
> memset the structure size, not the pointer size (fortunately, the structure size is greater than pointer size in this case).
> remove double parenthesis
> change false to 0 as pointer parameter
> use parenthesis to clarify preference between ? and +
> 
> 
> Diffs
> -----
> 
>   kdecore/sycoca/kmemfile.cpp a466bde 
>   kdeui/fonts/kfontchooser.cpp 541f7db 
>   kdeui/tests/ktabwidgettest.cpp fdc3161 
>   kross/modules/form.cpp 5e260c1 
>   kutils/kemoticons/kemoticonstheme.cpp c145741 
>   kutils/kpluginselector.cpp 0a39fcc 
> 
> Diff: http://git.reviewboard.kde.org/r/103165/diff/diff
> 
> 
> Testing
> -------
> 
> Still compiles with g++
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111117/f956d14b/attachment.htm>