Review Request: Fix wrong whatsThis strings in proxy kcm

Dawit Alemayehu adawit at kde.org
Mon Nov 14 16:56:23 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103131/#review8197
-----------------------------------------------------------

Ship it!


There is no longer any default value set for any of them. Please remove anything that talks about default values from all and commit that. Thanks.

- Dawit Alemayehu


On Nov. 14, 2011, 10:24 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103131/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2011, 10:24 a.m.)
> 
> 
> Review request for KDE Base Apps and Dawit Alemayehu.
> 
> 
> Description
> -------
> 
> Corrected whatsThis for HTTPS and SOCKS and common port for socks.
> Could not find any default/common ports for FTP proxy server, therefore removed that.
> 
> 
> Diffs
> -----
> 
>   konqueror/settings/kio/kproxydlg.ui 2170e7d 
> 
> Diff: http://git.reviewboard.kde.org/r/103131/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111114/f724bc52/attachment.htm>


More information about the kde-core-devel mailing list