[proposal] Move all of the ksecretsservice components into kdeutils/ksecrets

Kevin Ottens ervin at kde.org
Sat Nov 12 09:11:45 GMT 2011


On Saturday 12 November 2011 01:01:15 Valentin Rusu wrote:
> As you may already know, the ksecretsservice API merging to the
> kdelibs/4.7 branch was no longer an acceptable solution because of
> recent frameworks related decisions. It was suggested to put it into
> it's separate repository, alongside with the
> kde-runtime/ksecretsserviced I also merged yesterday.
> 
> After thinking twice, I'd like to bring these components into the
> kdeutils/ksecrets repository.
> Are you ok with this?

Sounds like a bad idea to me because...
 
> A possible issue if that's ok for you: the kdeutils/kwallet will depend
> on this repository and it contains guard code to exclude
> ksecretsservice-related code if qca not found - that will be extended to
> the case ksecrets repository will not be found. This raises the problem
> of module dependencies: kdelibs needs to be built first, but if ksecrets
> was not compiled first, the required headers will not be there and as
> such kwallet will not have the ksecretsservice-related code.
> That looks like a circular reference :-)

... it creates this type of situation.

Any particular reason why you didn't stick to the separate repo solution as 
proposed earlier? For some reason I fail to see what motivated your change on 
that.

Regards.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud patron of KDE, http://www.kdab.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111112/ff9f3b41/attachment.sig>


More information about the kde-core-devel mailing list