Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103028/
-----------------------------------------------------------

Review request for kdelibs.


Description
-------

This is a second attempt at implementing PortableMediaPlayer for udev
back-end using media-player-info [3], the first attempt was [2] by
Alex Merry and this patch is heavily based on it. This patch relates to
a discussion at [1] and is just a first step, the second would
be to forward PMP interface from udev backed to udisks backed somehow
(udisks...Device interface provides NativePath attribute that links to
sysfs path that can help - on Linux)

[1] http://mail.kde.org/pipermail/kde-hardware-devel/2011-October/001481.html
[2] https://svn.reviewboard.kde.org/r/5853/
[3] http://www.freedesktop.org/wiki/Software/media-player-info

Care is taken not to change existing behaviour - e.g. when udev env
ID_MEDIA_PLAYER equals 1, behaviour is unchanged.

TODO: announce runtime-only media-player-info dependency for solid and
      add it to build instructions. libmtp >= 1.0.4 is also needed at
      runtime for detection of MTP devices to work. usbmuxd (dependency
      of libimobiledevice) is needed at runtime for detection of Apple
      iOS devices.
TODO: what about windows support?

The patch is against kdelibs KDE/4.7 branch, please forward-port.

CCBUG: 253671  # does not solve it yet, but is a first step
CCBUG: 269447
CCBUG: 269451
REVIEW: 103028
DIGEST: groundwork for better media device player detection
CCMAIL: amarok-devel at kde.org


Diffs
-----

  solid/solid/CMakeLists.txt 1a4adfa 
  solid/solid/backends/udev/udevdevice.cpp d6c7fb4 
  solid/solid/backends/udev/udevmanager.cpp 55e655b 
  solid/solid/backends/udev/udevportablemediaplayer.h e0348aa 
  solid/solid/backends/udev/udevportablemediaplayer.cpp 32a1893 
  solid/solid/ifaces/portablemediaplayer.h a73120a 
  solid/solid/xdgbasedirs.cpp PRE-CREATION 
  solid/solid/xdgbasedirs_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103028/diff/diff


Testing
-------

1. connect iPod
2. works:
$ solid-hardware details /org/kde/solid/udev/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc
udi = '/org/kde/solid/udev/sys/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/host6/target6:0:0/6:0:0:0/block/sdc'
  parent = '/org/kde/solid/udev'  (string)
  vendor = 'Apple'  (string)
  product = 'iPod'  (string)
  description = 'Portable Media Player'  (string)
  Block.major = 8  (0x8)  (int)
  Block.minor = 32  (0x20)  (int)
  Block.device = '/dev/sdc'  (string)
  PortableMediaPlayer.supportedProtocols = {'storage', 'ipod'}  (string list)
  PortableMediaPlayer.supportedDrivers = {'usb'}  (string list)

3. not yet:
$ solid-hardware details /org/freedesktop/UDisks/devices/sdc1
udi = '/org/freedesktop/UDisks/devices/sdc1'
  parent = '/org/freedesktop/UDisks/devices/sdc'  (string)
  vendor = 'Apple'  (string)
  product = 'MATOUSUV IP'  (string)
  description = 'MATOUSUV IP'  (string)
  Block.major = 8  (0x8)  (int)
  Block.minor = 33  (0x21)  (int)
  Block.device = '/dev/sdc1'  (string)
  StorageAccess.accessible = true  (bool)
  StorageAccess.filePath = '/media/MATOUSUV IP'  (string)
  StorageAccess.ignored = false  (bool)
  StorageVolume.ignored = false  (bool)
  StorageVolume.usage = 'FileSystem'  (0x2)  (enum)
  StorageVolume.fsType = 'vfat'  (string)
  StorageVolume.label = 'MATOUSUV IP'  (string)
  StorageVolume.uuid = '3141-5926'  (string)
  StorageVolume.size = 7888957440  (0x1d637f000)  (qulonglong)


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111105/24c19fd7/attachment.htm>