Review Request: Change KIO::DeleteJob to use KIO::http_delete for HTTP protocol

[Dawit Alemayehu]

> On Nov. 4, 2011, 11:20 a.m., David Faure wrote:
> > kio/kio/deletejob.cpp, line 100
> > <http://git.reviewboard.kde.org/r/103038/diff/1/?file=40185#file40185line100>
> >
> >     Could be file-static instead of class-static, so that it doesn't generate a symbol at all.

True, will do that.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103038/#review7939
-----------------------------------------------------------


On Nov. 3, 2011, 5:59 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103038/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 5:59 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> The attached patch changes KIO::DeleteJob to use KIO::http_delete in case of HTTP and WEBDAV requests. That way redirection will be properly handled and we can remove the workaround hack from the ioslave. The patch also performs a small clean up and micro optimization.
> 
> 
> Diffs
> -----
> 
>   kio/kio/deletejob.cpp 87c630a 
> 
> Diff: http://git.reviewboard.kde.org/r/103038/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111104/05171b53/attachment.htm>