Review Request: Start D-Bus after setting KDE_FULL_SESSION

[Kevin Kofler]

> On Aug. 3, 2011, 6:19 p.m., Oswald Buddenhagen wrote:
> > this sounds wrong. what if dbus is started earlier, e.g. by a PAM module? this can easily happen once we use the new SecretService.
> > there should be some interface to push environment variables "into the bus" after it is running. maybe it would be ok to read  a file with VAR=value assignments (one per line, no quoting whatsoever - printenv output) from a defined per-session location before activating services.
> 
> Kevin Krammer wrote:
>     I guess a D-Bus enabled app could actually check the workspace it is running on instead of falling back to the "detect by environment variable" hack.
>     E.g. by checking if Plasma Desktop's name is registered or ksmserver is the session server, etc.
> 
> Arno Rehn wrote:
>     I'm with Ossi here. And AFAIK the "detect by env var" way is the official way of detecting a full KDE session. Plasma Desktop alone doesn't make a full KDE session (or does it?).
>     This patch might not be a full fix, but it certainly improves the situation for many users. I think it should go in, but with a big "FIXME" marker.
> 
> Kevin Kofler wrote:
>     +1 to Ossi. This fix will NOT work in Fedora, because Fedora now starts D-Bus from xinitrc.

By the way, GTK+ applications in a KDE Plasma session are also affected by this issue (with GTK_RC_FILES as set by kcm-gtk and/or kde-workspace's krdb instead of KDE_FULL_SESSION): https://bugzilla.redhat.com/show_bug.cgi?id=727806


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102194/#review5362
-----------------------------------------------------------


On Aug. 3, 2011, 12:15 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102194/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2011, 12:15 p.m.)
> 
> 
> Review request for kdelibs, Kevin Kofler, George Kiagiadakis, and David Faure.
> 
> 
> Description
> -------
> 
> As described in bug 267770. Luckily, there is no KDE-specific initialization between D-Bus launch and setting KDE_FULL_SESSION, so interchanging them should not affect KDE itself.
> 
> 
> This addresses bug 267770.
>     http://bugs.kde.org/show_bug.cgi?id=267770
> 
> 
> Diffs
> -----
> 
>   startkde.cmake 92c8753 
> 
> Diff: http://git.reviewboard.kde.org/r/102194/diff/diff
> 
> 
> Testing
> -------
> 
> I don't know "D-Bus activated apps", I assume I don't have any, so I did not see any difference in startup.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111102/272d6ab0/attachment.htm>