Review Request: PATCH: Honor size and coordinates when creating new Konqueror windows

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101477/
-----------------------------------------------------------

Review request for KDE Base Apps and David Faure.


Summary
-------

Currently new window creation in KonqMainWindow::slotCreateNewWindow does not honor the supplied cooridnate and size information under certain circumstances. For example, if you click on a javascript link that opens a new window, then the new window will always be maximized, regardless of the size information supplied by the javascript window.open call, as long as the Konqueror window where you clicked on the link is also maximized. Even when the original window is not maximized, if you maximize and close the newly created window, then clicking on the javscript window.open link again will result in a maximized window.

The attached patch addresses all of the above issues by making sure the coordinate and size information are always honored during new window creation.


Diffs
-----

  konqueror/src/konqmainwindow.cpp 56aa379 

Diff: http://git.reviewboard.kde.org/r/101477/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110531/adab82cf/attachment.htm>