Review Request: make the add search engine window right aligned to the search bar

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101475/#review3599
-----------------------------------------------------------

Ship it!


Would that not simply make the reverse true, i.e. the dialog might be too large in the opposite direction ? Anyhow, at least it won't be outside of the konqueror window ; so I personally have no objections to this.

- Dawit


On May 30, 2011, 8:26 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101475/
> -----------------------------------------------------------
> 
> (Updated May 30, 2011, 8:26 p.m.)
> 
> 
> Review request for KDE Base Apps, Dawit Alemayehu and David Faure.
> 
> 
> Summary
> -------
> 
> Currently the add search engine window is left aligned to the left side of the search bar. E. g. using locales with long translations of the window title "Set URI Shortcuts" (or other strings in the window) like eg fr part of the window to add the search engine is outside the screen, because the translated string is longer than the search bar. 
> The patch makes the window right aligned at the end of the search bar, than no matter how long the translated string is the whole window will be always inside konquerors main window.
> 
> Screenshot in locale fr before the patch showing the bug: http://bugsfiles.kde.org/attachment.cgi?id=52424
> 
> Screenshot in locale fr with the patch (one with / one without throbber): http://bugsfiles.kde.org/attachment.cgi?id=60484
> 
> 
> This addresses bug 253879.
>     http://bugs.kde.org/show_bug.cgi?id=253879
> 
> 
> Diffs
> -----
> 
>   konq-plugins/searchbar/searchbar.cpp c7aa301 
> 
> Diff: http://git.reviewboard.kde.org/r/101475/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110530/92f819b6/attachment.htm>