Review Request: make folderview icons translucent if composite is enabled

[Mathias Stephan Panzenböck]

> On May 29, 2011, 1:05 p.m., Thomas Lübking wrote:
> > Not sure wheher it's really worth it (though using ARGB over XShape might actually bring better performance) but I assume the style (oxygen) can deal this more efficiently (via polishment) and also globally (not only for the folderview plasmoid but _all_ Qt icon drags)
> > Gonna try and send Hugo a "patch" if it works.
> 
> Thomas Lübking wrote:
>     Yes, is. As trivial as
>     if (widget->testAttribute(Qt::WA_X11NetWmWindowTypeDND) && FX::compositingActive()) // uses KWindowSystem, FX is bespin
>     {
>        widget->setAttribute(Qt::WA_TranslucentBackground);
>        widget->clearMask();
>     }

If you have *a lot* of desktop icons and drag them all, the current code (using a mask and no ARGB window) makes kwin so slow, that the automatic desktop effects deactivation kicks in. So I think just for that it is worth to apply this (or a similar) patch. Also I think using these masked icons are really ugly. If no ARGB window can be used it would be better to use drag icons like dolphin does.


- Mathias Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/#review3574
-----------------------------------------------------------


On May 28, 2011, 8:57 p.m., Mathias Stephan Panzenböck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101463/
> -----------------------------------------------------------
> 
> (Updated May 28, 2011, 8:57 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine.
> 
> The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows:
> http://bugreports.qt.nokia.com/browse/QTBUG-8519
> 
> 
> This addresses bug 256475.
>     http://bugs.kde.org/show_bug.cgi?id=256475
> 
> 
> Diffs
> -----
> 
>   plasma/applets/folderview/iconview.h 4d736c5 
>   plasma/applets/folderview/iconview.cpp 206aff7 
> 
> Diff: http://git.reviewboard.kde.org/r/101463/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mathias Stephan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110529/d84ba9e8/attachment.htm>