Review Request: Set the main window on KDirLister created in DolphinView::ViewAccessor

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101469/#review3580
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks good!

- Peter


On May 29, 2011, 7:14 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101469/
> -----------------------------------------------------------
> 
> (Updated May 29, 2011, 7:14 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> The attached patch fixes problems where Dolphin asks for passwords too many times when accessing remote servers. This issue happens because the main window is never associated with the KDirLister created by DolphinView::ViewAccessor. As a result, when KDirLister uses KIO to retrieve content from remote server that requires authorization, the password supplied by the user is never cached properly in KPasswdServer (missing window-id).
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinview.cpp 1df8643 
> 
> Diff: http://git.reviewboard.kde.org/r/101469/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110529/f3adcb02/attachment.htm>