Review Request: make folderview icons translucent if composite is enabled

Sat May 28 21:57:59 BST 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101463/
-----------------------------------------------------------

Review request for KDE Base Apps.

Summary
-------

This patch makes dragged folderview icons translucent if composite is enabled. It is a kinda hack that uses an event filter to find Qt's D'n'D window, clears any mask on it and sets the Qt::WA_TranslucentBackground attribute. I use it day to day and it works fine.

The proper place to fix this would be in Qt, but they wrongfully marked the bug report as invalid, because they think X11 does not support translucent windows:
http://bugreports.qt.nokia.com/browse/QTBUG-8519

This addresses bug 256475.
    http://bugs.kde.org/show_bug.cgi?id=256475

Diffs
-----

  plasma/applets/folderview/iconview.h 4d736c5 
  plasma/applets/folderview/iconview.cpp 206aff7 

Diff: http://git.reviewboard.kde.org/r/101463/diff

Testing
-------

Thanks,

Mathias Stephan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110528/6048f9f1/attachment.htm>