Review Request:

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101454/#review3553
-----------------------------------------------------------


If "Rename Inline" is enabled, DolphinView::renameSelectedItems() calls m_viewAccessor.itemView()->edit(proxyIndex), which then opens the editor in KFileItemDelegate. When the editing is done, KFileItemDelegate::setModelData(...) is called, which calls KDirModel::setData(...), where the actual file renaming is triggered. Maybe the check could be done there, but you might want to ask David Faure about that.

- Frank


On May 27, 2011, 10:19 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101454/
> -----------------------------------------------------------
> 
> (Updated May 27, 2011, 10:19 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> So far this works only for the RenameDialog as I could not find the method that changes the name when inline renaming is enabled.
> If you could tell me where that method is I would in fact adapt the patch.
> 
> 
> This addresses bug 211751.
>     http://bugs.kde.org/show_bug.cgi?id=211751
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/renamedialog.cpp 810562a 
> 
> Diff: http://git.reviewboard.kde.org/r/101454/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110527/26976fd2/attachment.htm>