Review Request: startkde.cmake should treat font dpi like kcontrol/krdb/krdb.cpp does

[Lukas Sommer]

> On May 25, 2011, 10:19 a.m., Christoph Feck wrote:
> > The big problem with this patch is that the user interface only offers a ComboBox with two fixed values. What does the interface show when you modified the value to, say, 200 dpi?

Well, the user interface offers three different values: "96 dpi", "120 dpi" and "disabled". Any value different from 96 and 120 will be interpreted by the user interface as "disabled".

However, kcontrol/krdb/krdb.cpp does yet process all values, also when they are not 96 or 120.

Should I also come up with a separate patch to the UI? Or integrate a patch to the UI in this patch?


- Lukas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101410/#review3505
-----------------------------------------------------------


On May 22, 2011, 9:48 a.m., Lukas Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101410/
> -----------------------------------------------------------
> 
> (Updated May 22, 2011, 9:48 a.m.)
> 
> 
> Review request for KDE Base Apps, KDE Runtime and kdelibs.
> 
> 
> Summary
> -------
> 
> I've been experimenting a little bit with custom font dpi sizes in $HOME/.kde4/share/config/kcmfonts
> 
> There, you can set custom font dpi value. Although the user interface (systemsettings/fonts) only provides 0 (don't force a dpi, use the system default instead), 96 and 120 as choice, in the config file you can put (manually) arbitrary values. This works mostly fine because kcontrol/krdb/krdb.cpp simply processes the dpi value of the config file "as is".
> 
> However, startkde.cmake doesn't. It checks if the value is 96 or 120. If not, the value is ignored and the system default is used.
> 
> Result: When you use e.g. 200 as dpi value and restart KDE, then KWin uses the default value (96 dpi on my system) for the window title, while the applications themself are displayed using 200 dpi. So the applications fonts are as big as desired, but the window title is too small. See the attached screenshot. This behaviour is inconsistent. startkde.cmake should follow the same police as kcontrol/krdb/krdb.cpp does. This patch fixes this.
> 
> (The user interface could be adopted in another patch.)
> 
> (Make this work would benefit people who need a high display resolution. Example: You connect your computer to your plasma tv and you want to be still be able to read the text although you are at a distance of 5 meters from the tv monitor. See also bug 272266)
> 
> 
> Diffs
> -----
> 
>   startkde.cmake dde9c23 
> 
> Diff: http://git.reviewboard.kde.org/r/101410/diff
> 
> 
> Testing
> -------
> 
> I've applied the patch to my local /usr/bin/startkde file, and it works fine.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101410/s/171/
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110527/97017a7c/attachment.htm>