Review Request: Catch a bogus username in a url intented to fool a user into visiting a site unintentionally

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101440/#review3530
-----------------------------------------------------------



kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/101440/#comment2961>

    You are not using i18nc correctly, you need to have the parameters inside the call, not use arg


- Albert


On May 25, 2011, 6:14 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101440/
> -----------------------------------------------------------
> 
> (Updated May 25, 2011, 6:14 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> The attached KIO HTTP patch adds the same kind of preventative measure as Mozilla to stop a user from being fooled into visiting a site through the "bogus username" trick. For example, http://www.microsoft.com%26item%3Dq209354rexsddiuyjkiuylkuryt2583453453fsesfsdfsfasfdfdsf@www.kde.org/.
> 
> 
> This addresses bug 94867.
>     http://bugs.kde.org/show_bug.cgi?id=94867
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.cpp b937856 
> 
> Diff: http://git.reviewboard.kde.org/r/101440/diff
> 
> 
> Testing
> -------
> 
> Tested using the links provided in bug report a sample of which is provided in the description area above.
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110525/8b4d2330/attachment.htm>