Review Request: Ignores dots at the beginning of a file name when suggesting a file name

Matthias Fuchs mat69 at gmx.net
Tue May 24 11:55:09 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101429/
-----------------------------------------------------------

(Updated May 24, 2011, 10:55 a.m.)


Review request for kdelibs and David Faure.


Changes
-------

Now handles any number of preceding dots ('.').
Tested with files called ".......", "..aFile.tar.gz" as well as the previous mentioned ones.

Just in case: Are there unit tests for the suggestNewName method that I could run as well?


Summary
-------

This ensures that ".aFile.tar.gz" becomes ".aFile 1.tar.gz" instead of " 1.aFile.tar.gz".

I would also backport this to the 4.6 branch.


Diffs (updated)
-----

  kio/kio/renamedialog.cpp 9afb872 

Diff: http://git.reviewboard.kde.org/r/101429/diff


Testing
-------

Test with files with the following names "a", ".a", "aFile.tar", "aFile.tar.gz", ".aFile.tar.gz". Works as described.


Thanks,

Matthias

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110524/f933e1ac/attachment.htm>


More information about the kde-core-devel mailing list