Review Request: Added include files for two widgets

John Layt john at layt.net
Mon May 23 08:41:30 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101421/#review3457
-----------------------------------------------------------

Ship it!


I'm pretty sure that's a KRatingWidget and not a KRantingWidget although they are easily confused :-)  Otherwise looks fine.

- John


On May 22, 2011, 11:22 p.m., Jon Ander PeƱalba wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101421/
> -----------------------------------------------------------
> 
> (Updated May 22, 2011, 11:22 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KRantingWidget and KShortcutWidget didn't have an include file with the same name as the class, this patch simply adds this files.
> 
> 
> Diffs
> -----
> 
>   includes/CMakeLists.txt 0a80219 
>   includes/KRantingWidget PRE-CREATION 
>   includes/KShortcutWidget PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101421/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Ander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110523/a3d3d98d/attachment.htm>


More information about the kde-core-devel mailing list