Review Request: Better documentation for KConfigDialog::addPage()

Commit Hook null at kde.org
Sun May 22 19:45:11 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101409/#review3453
-----------------------------------------------------------


This review has been submitted with commit 6379152334a4857f8ddee65d0b000fe1a836c366 by Aaron Seigo.

- Commit


On May 21, 2011, 11:03 a.m., Lukas Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101409/
> -----------------------------------------------------------
> 
> (Updated May 21, 2011, 11:03 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The documentation of KConfigDialog::addPage() is not very detailed about the parameter "pixmapName". This patch adds to the documentation that it is possible to simply pass the KDE icon name instead of the pixmap path.
> 
> 
> This addresses bug 273723.
>     http://bugs.kde.org/show_bug.cgi?id=273723
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kconfigdialog.h 873460b 
> 
> Diff: http://git.reviewboard.kde.org/r/101409/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110522/eae8913a/attachment.htm>


More information about the kde-core-devel mailing list