Review Request: Avoid resolving host names in TCPSlaveBase::connectToHost

Commit Hook null at kde.org
Fri May 20 02:45:10 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101338/#review3412
-----------------------------------------------------------


This review has been submitted with commit 65aabc8c6df6d25fc35d06ad880ecdc9a2e43291 by Dawit Alemayehu.

- Commit


On May 11, 2011, 6:17 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101338/
> -----------------------------------------------------------
> 
> (Updated May 11, 2011, 6:17 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch basically reverts commit 79c4ed8a7c7fe18f4c1d02d5faba5e7a412f57ae which was a workaround for bugs in hardware that is no longer applicable. The revert will ensure that a hostname and not an ip address is used for HTTPS over HTTP proxy (aka CONNECT) connections.
> 
> 
> This addresses bug 207550.
>     http://bugs.kde.org/show_bug.cgi?id=207550
> 
> 
> Diffs
> -----
> 
>   kio/kio/tcpslavebase.cpp 19e36c3 
> 
> Diff: http://git.reviewboard.kde.org/r/101338/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110520/49548d64/attachment.htm>


More information about the kde-core-devel mailing list