Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101374/#review3375
-----------------------------------------------------------


WRT the parenthesis ... the outermost if statement breaks before the opening paren, the second if statement uses paren on the same line as the statement and the third uses no parens at all. Might that be worth unifying?

- Frederik


On May 17, 2011, 9:18 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101374/
> -----------------------------------------------------------
> 
> (Updated May 17, 2011, 9:18 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Peter Penz.
> 
> 
> Summary
> -------
> 
> Konqueror in filemanager mode shows an empty tab title on browsing root (/) folder. Dolphin displays the tab title on root (/) folder properly, so this patch is a copy of three lines from dolphin dolphinmainwindow.cpp.
> 
> 
> This addresses bug 153573.
>     http://bugs.kde.org/show_bug.cgi?id=153573
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqview.cpp 699c9d5 
> 
> Diff: http://git.reviewboard.kde.org/r/101374/diff
> 
> 
> Testing
> -------
> 
> compiled and works for me
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110517/69457309/attachment.htm>