Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101374/#review3366
-----------------------------------------------------------



konqueror/src/konqview.cpp
<http://git.reviewboard.kde.org/r/101374/#comment2804>

    oops... there is already a url.isLocalFile() above. I did not see that before. That means the isEmpty by itself is sufficient.


- Dawit


On May 17, 2011, 8:05 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101374/
> -----------------------------------------------------------
> 
> (Updated May 17, 2011, 8:05 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Peter Penz.
> 
> 
> Summary
> -------
> 
> Konqueror in filemanager mode shows an empty tab title on browsing root (/) folder. Dolphin displays the tab title on root (/) folder properly, so this patch is a copy of three lines from dolphin dolphinmainwindow.cpp.
> 
> 
> This addresses bug 153573.
>     http://bugs.kde.org/show_bug.cgi?id=153573
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqview.cpp 699c9d5 
> 
> Diff: http://git.reviewboard.kde.org/r/101374/diff
> 
> 
> Testing
> -------
> 
> compiled and works for me
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110517/4107621f/attachment.htm>