Review Request: add help button + action to Spell Checking Configuration dialog lanched from apps (kmail, konqui etc)

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101373/#review3363
-----------------------------------------------------------

Ship it!


could you also make sure to cherry-pick this into the 4.6 branch?

- Allen


On May 16, 2011, 9:08 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101373/
> -----------------------------------------------------------
> 
> (Updated May 16, 2011, 9:08 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Launching the dialog in systemsettings (Locale->Spell Checker) it has a Help button opening the docbook help:/kcontrol/spellchecking/. But using this dialog from several apps (konqui->Tools->Configure Spell Checking, kmail composer Settings menu etc) this help button is missing.
> 
> 
> This addresses bug 213817.
>     http://bugs.kde.org/show_bug.cgi?id=213817
> 
> 
> Diffs
> -----
> 
>   kdeui/sonnet/configdialog.cpp 8bb4923 
> 
> Diff: http://git.reviewboard.kde.org/r/101373/diff
> 
> 
> Testing
> -------
> 
> build, works.
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110517/bca45361/attachment.htm>