Review Request: Display the tab title on root (/) folder properly in konqueror filemanager mode

[Dawit Alemayehu]

> On May 16, 2011, 9:36 p.m., Peter Penz wrote:
> > The patch is fine from my point of view, but Konqueror is maintained by David Faure -> it's up to David for a final "ship it" :-)

Actually the bug here is the fact that url.fileName() is used to retrieve a directory name. Though that does not make sense, at least not to me, it works correctly for non-root paths  because fileName() ignores trailing slashes by default. IOW, it works because by default the fileName function treats the last path as if it is a file, which to me, seems very hackish. Anyhow, your fix unnecessarily creates a temporary KUrl object that will to additionally parse "file:///". You could achieve the same thing without such cost by adding

if (adjustCaption.isEmpty() && url.isLocalFile())
   adjustCaption = QLatin1Char('/');

after the "adjustCaption = url.fileName()" call.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101374/#review3354
-----------------------------------------------------------


On May 16, 2011, 9:43 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101374/
> -----------------------------------------------------------
> 
> (Updated May 16, 2011, 9:43 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Peter Penz.
> 
> 
> Summary
> -------
> 
> Konqueror in filemanager mode shows an empty tab title on browsing root (/) folder. Dolphin displays the tab title on root (/) folder properly, so this patch is a copy of three lines from dolphin dolphinmainwindow.cpp.
> 
> 
> This addresses bug 153573.
>     http://bugs.kde.org/show_bug.cgi?id=153573
> 
> 
> Diffs
> -----
> 
>   konqueror/src/konqview.cpp 699c9d5 
> 
> Diff: http://git.reviewboard.kde.org/r/101374/diff
> 
> 
> Testing
> -------
> 
> compiled and works for me
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110516/c25f0b7b/attachment.htm>