Review Request: konqueror: reset URL when pressing ESC in address bar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6681/#review10125
-----------------------------------------------------------


Why do this in a key press handler? It means that hitting the Stop button with the mouse and pressing the Esc key will do something different.

Better do this in the slot connected to the stop action, then it will work for both.

- David


On May 15, 2011, 7:59 p.m., Marcel Partap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6681/
> -----------------------------------------------------------
> 
> (Updated May 15, 2011, 7:59 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> Attempted patch to make konqueror reset the URL when escape is pressed in the address bar. For reasons beyond my grokledge does not always seem to work.
> 
> 
> This addresses bug 257841.
>     https://bugs.kde.org/show_bug.cgi?id=257841
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/src/konqmainwindow.cpp 1200388 
> 
> Diff: http://svn.reviewboard.kde.org/r/6681/diff
> 
> 
> Testing
> -------
> 
> see https://bugs.kde.org/show_bug.cgi?id=257841#c0
> 
> 
> Thanks,
> 
> Marcel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110516/e05eb7ed/attachment.htm>