Review Request: PATCH: Change the default KIO USERAGENT string.

[Dawit Alemayehu]

> On May 11, 2011, 4:19 p.m., Alex Merry wrote:
> > kio/kio/kprotocolmanager.cpp, line 350
> > <http://git.reviewboard.kde.org/r/101337/diff/1/?file=16340#file16340line350>
> >
> >     Wouldn't asyncCall be better, since we don't care about the reply?  Or just pass QDBus::NoBlock to call().

Currently nothing a single thing uses that KProtocolManager function, but personally I have not objection to making it an async call. In fact one of my remaining pieces for the proxy overhaul patches will do exactly that since it will then be in use. Hence that change will be forth coming in a future bug fix.


> On May 11, 2011, 4:19 p.m., Alex Merry wrote:
> > kio/kio/kprotocolmanager.cpp, line 628
> > <http://git.reviewboard.kde.org/r/101337/diff/1/?file=16340#file16340line628>
> >
> >     Why the change?

No idea. Probably copy and paste without thinking ? Will fix that before commit.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101337/#review3262
-----------------------------------------------------------


On May 11, 2011, 4 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101337/
> -----------------------------------------------------------
> 
> (Updated May 11, 2011, 4 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch changes the default user-agent string so that it is more aligned with other browsers by
>     - Dropping 'comptiable' and 'U' from the string.
>     - Making the platform string, e.g X11, mandatory part of the string.
>     - Sending the OS name and machine type (i686,x86-64) by default (configurable).
> 
> Additionally the patch for kprotocolmanager.cpp also removes the manual use of '%' to append text since kdelibs is now compilable with the QT_USE_FAST_CONCATENATION and QT_USE_FAST_OPERATOR_PLUS flags.
>     
> Besides being good for privacy due to less differentiation, this change should make it less likely that a different page will be sent sheerly based on user-agent sniffing. See the attached screen shot for what the full, default, and minimal default user-agent will look like now.
> 
> 
> This addresses bug 271720.
>     http://bugs.kde.org/show_bug.cgi?id=271720
> 
> 
> Diffs
> -----
> 
>   kio/kio/http_slave_defaults.h af97cfa 
>   kio/kio/kprotocolmanager.cpp 57ec696 
> 
> Diff: http://git.reviewboard.kde.org/r/101337/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> UserAgent [FULL]
>   http://git.reviewboard.kde.org/r/101337/s/163/
> UserAgent [Default]
>   http://git.reviewboard.kde.org/r/101337/s/164/
> UserAgent [Minimal]
>   http://git.reviewboard.kde.org/r/101337/s/165/
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110511/04531f25/attachment.htm>