Review Request: Enable kdialog to set an icon for passivepopup as well

[David Palacio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3228
-----------------------------------------------------------



kdialog/kdialog.cpp
<http://git.reviewboard.kde.org/r/101282/#comment2726>

    --icon is a KDE option.
    Maybe that's why the first diff did not work?



kdialog/kdialog.cpp
<http://git.reviewboard.kde.org/r/101282/#comment2727>

    s/duration/timeout
    There's no need to change this name here and you change it backwards some lines below. KDialog's usage text names this option "timeout" as well.


- David


On May 6, 2011, 2:52 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101282/
> -----------------------------------------------------------
> 
> (Updated May 6, 2011, 2:52 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma notifications as well.
> I saw that the icon was hardcoded to dialog-information and tried to enable it to parse the --icon command line argument and pass it to the dbus call that triggers the notification.
> I could not test the patch however, since I do not (yet) have a full development environment or its dependencies, and I do not even know if this is the right approach, but I hope you can have a look at it.
> 
> 
> Diffs
> -----
> 
>   kdialog/kdialog.cpp b80ad9a 
> 
> Diff: http://git.reviewboard.kde.org/r/101282/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110509/02522dc4/attachment.htm>