Review Request: Enable kdialog to set an icon for passivepopup as well

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
-----------------------------------------------------------

(Updated May 5, 2011, 3:57 p.m.)


Review request for KDE Base Apps.


Changes
-------

The --icon parameter did not work as expected, so I added a new one --passiveicon which purpose is only to set the icon for --passivepopup.
Compiled fine, tested it and icon is changeable for passivepopup.
Usage: kdialog --passivepopup "your message" --passiveicon "someicon"


Summary
-------

Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma notifications as well.
I saw that the icon was hardcoded to dialog-information and tried to enable it to parse the --icon command line argument and pass it to the dbus call that triggers the notification.
I could not test the patch however, since I do not (yet) have a full development environment or its dependencies, and I do not even know if this is the right approach, but I hope you can have a look at it.


Diffs (updated)
-----

  kdialog/kdialog.cpp b80ad9a 

Diff: http://git.reviewboard.kde.org/r/101282/diff


Testing
-------


Thanks,

Kai Uwe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110505/c97cdcee/attachment.htm>