Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

[Dawit Alemayehu]

> On May 2, 2011, 8:26 p.m., Dawit Alemayehu wrote:
> > Instead of doing all that, please rename the local static function in accessmanagerreply_p.cpp to "isLocalResource(...)" and be done with it.
> 
> Nicolas Alvarez wrote:
>     So the one checking for scheme=="data" should remain isLocalRequest, and the one not checking for "data" should be isLocalResource?
>     
>     I don't really understand those names; maybe the functions need doxygen even if they're static :)

Then, you can change it to  "doesSchemeMatchLocalResource" and the isLocalRequest in accessmanager.cpp can be renamed to "isRequestLocalResource", if you are so inclined to do so. Perhaps those are much more descriptive names.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101277/#review3076
-----------------------------------------------------------


On May 2, 2011, 9:34 p.m., Nicolas Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101277/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 9:34 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. The first problem is in kio, where there's two file-static functions with the same name (isLocalRequest) and slightly different code.
> 
> Fixed by renaming one of the functions.
> 
> 
> Diffs
> -----
> 
>   kio/kio/accessmanagerreply_p.cpp ccc7474799734b91112d70dc81945b8fe9b9f96c 
> 
> Diff: http://git.reviewboard.kde.org/r/101277/diff
> 
> 
> Testing
> -------
> 
> Compilation of kdelibs/kio with and without final. Didn't try installing or running.
> Other parts of kdelibs still don't work with final.
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110503/f4c9f1bb/attachment.htm>