Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101277/#review3076
-----------------------------------------------------------


Instead of doing all that, please rename the local static function in accessmanagerreply_p.cpp to "isLocalResource(...)" and be done with it.


kio/kio/accessmanager.cpp
<http://git.reviewboard.kde.org/r/101277/#comment2624>

    Can you also remove this trailing space while you are at it ?  Thanks.


- Dawit


On May 2, 2011, 7:26 p.m., Nicolas Alvarez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101277/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 7:26 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. The first problem is in kio, where there's two file-static functions with the same name (isLocalRequest) and slightly different code.
> 
> This patch fixes kio compilation by moving the two isLocalRequest functions into the corresponding private classes.
> 
> 
> Diffs
> -----
> 
>   kio/kio/accessmanager.cpp 03b75898b0fcc6b47518fde8a8b3afc23a1a677f 
>   kio/kio/accessmanagerreply_p.h 408b5331c999633f4f5d603a70cb419678249a7e 
>   kio/kio/accessmanagerreply_p.cpp ccc7474799734b91112d70dc81945b8fe9b9f96c 
> 
> Diff: http://git.reviewboard.kde.org/r/101277/diff
> 
> 
> Testing
> -------
> 
> Compilation of kdelibs/kio with and without final. Didn't try installing or running.
> Other parts of kdelibs still don't work with final.
> 
> 
> Thanks,
> 
> Nicolas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110502/bcc4b5e4/attachment.htm>