Review Request: Fix compile of KIO with KDE_ENABLE_FINAL enabled.

[Nicolas Alvarez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101277/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

kdelibs compilation is broken with KDE4_ENABLE_FINAL turned ON. The first problem is in kio, where there's two file-static functions with the same name (isLocalRequest) and slightly different code.

This patch fixes kio compilation by moving the two isLocalRequest functions into the corresponding private classes.


Diffs
-----

  kio/kio/accessmanager.cpp 03b75898b0fcc6b47518fde8a8b3afc23a1a677f 
  kio/kio/accessmanagerreply_p.h 408b5331c999633f4f5d603a70cb419678249a7e 
  kio/kio/accessmanagerreply_p.cpp ccc7474799734b91112d70dc81945b8fe9b9f96c 

Diff: http://git.reviewboard.kde.org/r/101277/diff


Testing
-------

Compilation of kdelibs/kio with and without final. Didn't try installing or running.
Other parts of kdelibs still don't work with final.


Thanks,

Nicolas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110502/609eeffd/attachment.htm>