Review Request: KMessageWidget: Adapt height to text changes

Aurélien Gâteau agateau at kde.org
Mon May 2 18:49:33 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101272/#review3071
-----------------------------------------------------------


Thanks for the patch Mattias! This is indeed an annoying bug but your fix does not work when the widget is resized. heightForWidth() needs to be implemented I think.

- Aurélien


On May 2, 2011, 12:35 p.m., Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101272/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 12:35 p.m.)
> 
> 
> Review request for kdelibs and Aurélien Gâteau.
> 
> 
> Summary
> -------
> 
> When there is a long or wrapping text, the text is cut off. This patch fixes that.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmessagewidget.cpp 212ea0d 
> 
> Diff: http://git.reviewboard.kde.org/r/101272/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101272/s/154/
> 
>   http://git.reviewboard.kde.org/r/101272/s/155/
> 
> 
> Thanks,
> 
> Matthias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110502/6f8b2356/attachment.htm>


More information about the kde-core-devel mailing list