Review Request: Add KMessageWidget, an alternative to KMessageBox

[Aaron J. Seigo]

> On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote:
> > You seem to be missing the addition of the uppercase include in kdelibs/includes

i already fixed that :)


> On May 1, 2011, 11:44 a.m., Albert Astals Cid wrote:
> > kdeui/widgets/kmessagewidget.h, line 26
> > <http://git.reviewboard.kde.org/r/101249/diff/3/?file=15637#file15637line26>
> >
> >     Do we really need this include here?

fixed


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101249/#review3007
-----------------------------------------------------------


On April 30, 2011, 1:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101249/
> -----------------------------------------------------------
> 
> (Updated April 30, 2011, 1:10 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> KMessageWidget is a new widget which can be considered as a less intrusive alternative for KMessageBox. It was designed during KDE UX sprint 2011 ( http://community.kde.org/Sprints/UX2011/KMessageWidget ).
> 
> The class documentation should make it clear how and when it can be used.
> 
> This widget could be used by:
> - Browsers to implement their "remember password" widgets (Konqueror, Rekonq...)
> - Forms to provide feedback on validation errors
> - Bluedevil KCM to replace its custom "No Bluetooth adapter have been found" message widget
> - Nepomuk/Strigi KCM to indicate status of their services
> - Gwenview to replace its custom save bar
> - ...
> 
> I still have a few additions in mind for the API but it is already usable and since we are freezing I think it can be merged in master in its current state. I assume it will still be possible to extend the API a bit before kdelibs 4.7 freezes for good.
> 
> I also wrote an example program in the kdeexample repository ( https://projects.kde.org/projects/kde/kdeexamples/repository/show?rev=agateau%2Fkmessagewidget ), though I am wondering whether it shouldn't be moved in kdeui/tests as it is more a manual test program than an example.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt d1873d154f4dde92c29f2e6dab1be70d49ddb55e 
>   kdeui/widgets/kmessagewidget.h PRE-CREATION 
>   kdeui/widgets/kmessagewidget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101249/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Montage from kmessagewidgetdemo
>   http://git.reviewboard.kde.org/r/101249/s/141/
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110501/371df573/attachment.htm>