Review Request: PATCH: FTP handle files that start or stop with whitespaces

Dawit Alemayehu adawit at kde.org
Mon Mar 28 21:31:48 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100943/
-----------------------------------------------------------

(Updated March 28, 2011, 8:31 p.m.)


Review request for kdelibs and David Faure.


Summary
-------

The attach patch is a fix for the bug report above. The fix is achieved by removing the trimmed() calls at stated in the summary. However, a comment above the affected code states the following:

        // Some sites put more than one space between the date and the name
        // e.g. ftp://ftp.uni-marburg.de/mirror/

Unfortunately, the provided address does not contain any files ; so it is rather difficult to test whether removing the trimmed call breaks it or not ; so I am posting this patch for here for input...


This addresses bug 88575.
    http://bugs.kde.org/show_bug.cgi?id=88575


Diffs
-----

  kioslave/ftp/ftp.cpp 77675a0 

Diff: http://git.reviewboard.kde.org/r/100943/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110328/b10022e7/attachment.htm>


More information about the kde-core-devel mailing list