Review Request: A new autoptr class for QPointer.

Alex Merry kde at randomguy3.me.uk
Sat Mar 26 13:20:28 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/955/#review10028
-----------------------------------------------------------


Do we still want this?  We now have QScopedPointer, but it doesn't do quite what this does (it doesn't watch for QObjects being deleted).

- Alex


On July 8, 2009, 10:12 a.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/955/
> -----------------------------------------------------------
> 
> (Updated July 8, 2009, 10:12 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This template class is inherited from QPointer, and provides the additional feature that on destruction it deletes the QObject whose pointer it contains.
> 
> The motivation for adding this class is to deal with the issue described in  http://www.kdedevelopers.org/node/3919, whereby if a modal dialog is open when an application is told to quit, the dialog will be deleted by its parent, usually resulting in a crash due to double deletion of the dialog, or due to accessing the dangling pointer to the dialog.
> 
> This class is required by several applications in kdepim, and other modules would also benefit by using it.
> 
> A unit test will be provided if the class is approved.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/util/kautopointer.h PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/955/diff
> 
> 
> Testing
> -------
> 
> Works successfully in KAlarm.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110326/376abc1d/attachment.htm>


More information about the kde-core-devel mailing list