Re: Review Request: Adding Ångström to KUnitConversion

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100923/#review2109
-----------------------------------------------------------



kunitconversion/length.cpp
<http://git.reviewboard.kde.org/r/100923/#comment1746>

    You missed "Angstrom". Accents are too hard for some of us. :) Plural forms might be good too.


- Parker


On March 22, 2011, 8:43 p.m., Etienne Rebetez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100923/
> -----------------------------------------------------------
> 
> (Updated March 22, 2011, 8:43 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Hi,
> Just adding Ångström as a lenght unit to kunitcoversion. 
> I plan to integrate KUnitConversion into Kalzium. Since the lenght values of elements in ements.xml are stored in Ångström i need that unit to.
> 
> http://en.wikipedia.org/wiki/%C3%85ngstr%C3%B6m
> 
> Etienne
> 
> 
> Diffs
> -----
> 
>   kunitconversion/converter.h f52b602 
>   kunitconversion/length.cpp d734443 
> 
> Diff: http://git.reviewboard.kde.org/r/100923/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Etienne
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110322/a65d7720/attachment.htm>