Review Request: Fix handling of FTP urls whose path name ends with a type code
David Faure
faure at kde.org
Fri Mar 18 19:58:52 GMT 2011
On Wednesday 16 March 2011, Thiago Macieira wrote:
> Suggestion:
> path.left(path.length() - sizeof ";type=");
Unreadable.
> sizeof(";type=") == strlen(";type=X")
A hidden off-by-one, how nice to have in our code ;)
--
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
More information about the kde-core-devel
mailing list