Review Request: Fix handling of FTP urls whose path name ends with a type code

[Thiago Macieira]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100872/#review2005
-----------------------------------------------------------



kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/100872/#comment1675>

    Suggestion: 
        path.left(path.length() - sizeof ";type=");
    
    sizeof(";type=") == strlen(";type=X")



kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/100872/#comment1676>

    Use lastIndexOf.
    



kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/100872/#comment1677>

    use toLatin1() instead of toAscii()


- Thiago


On March 16, 2011, 3:23 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100872/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 3:23 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> As stated in the summary this patch fixes kio_ftp so that it can properly handle FTP urls that have transfer "type" information embedded in their path. Such FTP urls are legal in the old URI RFC, RFC 1738. Since the RFC that preceded it is neutral on this subject and both Firefox and Chrome support such urls, kio_ftp should too.
> 
> 
> This addresses bug 92589.
>     http://bugs.kde.org/show_bug.cgi?id=92589
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/ftp.cpp 038ac2e 
> 
> Diff: http://git.reviewboard.kde.org/r/100872/diff
> 
> 
> Testing
> -------
> 
> Clicked on the example link provided in the bug report. Note there is a secondary bug unrelated to this fix that prevents the click on the link from properly being handled once you choose an action.
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110316/ddb24a07/attachment.htm>