Review Request: Dolphin details view optimization

[Peter Penz]

> On March 10, 2011, 8:05 a.m., Peter Penz wrote:
> > Thanks a lot for this good patch, please commit :-) Would also be great if this could be backported to 4.6.2.

I've committed the patch and backported it to 4.6.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100826/#review1879
-----------------------------------------------------------


On March 9, 2011, 11:38 p.m., Samuel Rødal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100826/
> -----------------------------------------------------------
> 
> (Updated March 9, 2011, 11:38 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Constructing a KColorScheme object is very expensive because of a number
> of tint computations. When scrolling a big list more than 30 % of the
> time was spent here. Instead, we can precompute and store the inactive
> text color.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinfileitemdelegate.h 5eb559a7909a50afef8a67a8706ac3106dab38bb 
>   dolphin/src/views/dolphinfileitemdelegate.cpp 9fed95bca2a8170ddbc18239a990ce8a28528bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/100826/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110312/0d2402b2/attachment.htm>