Review Request: Add a GUI to configure window's title bar blend colours

[Christoph Feck]

> On March 8, 2011, 2:12 p.m., Hans Meine wrote:
> > kcontrol/colors/colorsettings.ui, line 615
> > <http://git.reviewboard.kde.org/r/100821/diff/1/?file=10768#file10768line615>
> >
> >     I believe to recall that "blend" was the term used in the past as well, but given that not all styles actually use this color for blending, wouldn't it be better to call it "secondary color"?
> >     
> >     I.e. "Active Titlebar Secondary [Color/Background]" or the like.
> >     
> >     I always found this wrong terminology to look unpolished when looking at the Quartz (IIRC) style.

Yep, the more generic name sounds better.

Given that there are more colors missing compared to KDE3 (mainly the button colors, which are used, e.g. by deKorator), I would suggest to add them too, and maybe move all window decoration related colors to a separate "section" in the colors KCM, or even to the module where KWin decorations are configured.

Please add the "kwin" group to reviewers to ask them for their opinion.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100821/#review1844
-----------------------------------------------------------


On March 8, 2011, 12:18 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100821/
> -----------------------------------------------------------
> 
> (Updated March 8, 2011, 12:18 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Some of the still available window decorations (KDE2, Keramik, Modern System, Quartz,
> Redmond) use two colours for the title bar, either as a blend or for different
> parts of the bar.  This patch extends the GUI in System Settings to allow the
> blend colour to be configured.
> 
> 
> This addresses bug 225837.
>     http://bugs.kde.org/show_bug.cgi?id=225837
> 
> 
> Diffs
> -----
> 
>   kcontrol/colors/colorscm.h 7627db8 
>   kcontrol/colors/colorscm.cpp 571ed86 
>   kcontrol/colors/colorsettings.ui efd618b 
> 
> Diff: http://git.reviewboard.kde.org/r/100821/diff
> 
> 
> Testing
> -------
> 
> Built kde-workspace with these changes, verified operation of systemsettings and KDE2 window decoration.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110308/deb7e386/attachment.htm>