Re: Review Request: Make “No multiscreen configuration” message prettier

Kai Uwe Broulik kde at privat.broulik.de
Thu Jun 30 21:20:47 BST 2011



> On June 30, 2011, 8:11 p.m., Ben Cooksley wrote:
> > kcontrol/xinerama/kcmxinerama.cpp, line 128
> > <http://git.reviewboard.kde.org/r/101810/diff/1/?file=25726#file25726line128>
> >
> >     Indentation?

Oh, I thought I corrected that o.O 


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/#review4284
-----------------------------------------------------------


On June 30, 2011, 5:48 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101810/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 5:48 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> I always found Bluedevil’s notifications so nice, so I patched the Multi monitor configuration KCM to use something similar to indicate that this configuration is not available on the respective machine.
> 
> Comparison screenshot: http://privat.broulik.de/xineramapatch.png
> 
> 
> Diffs
> -----
> 
>   kcontrol/xinerama/kcmxinerama.h fc83e5a 
>   kcontrol/xinerama/kcmxinerama.cpp 86fbf38 
> 
> Diff: http://git.reviewboard.kde.org/r/101810/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110630/fc9c041c/attachment.htm>


More information about the kde-core-devel mailing list