Re: Review Request: Make “No multiscreen configuration” message prettier
Ben Cooksley
bcooksley at kde.org
Thu Jun 30 21:50:28 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101810/#review4287
-----------------------------------------------------------
Ship it!
Looks good now
kcontrol/xinerama/kcmxinerama.cpp
<http://git.reviewboard.kde.org/r/101810/#comment3513>
You might want to seperate that into two lines like was done for the icon.
- Ben
On June 30, 2011, 8:47 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101810/
> -----------------------------------------------------------
>
> (Updated June 30, 2011, 8:47 p.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Summary
> -------
>
> I always found Bluedevil’s notifications so nice, so I patched the Multi monitor configuration KCM to use something similar to indicate that this configuration is not available on the respective machine.
>
> Comparison screenshot: http://privat.broulik.de/xineramapatch.png
>
>
> Diffs
> -----
>
> kcontrol/xinerama/kcmxinerama.h fc83e5a
> kcontrol/xinerama/kcmxinerama.cpp 86fbf38
>
> Diff: http://git.reviewboard.kde.org/r/101810/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110630/58603e9a/attachment.htm>
More information about the kde-core-devel
mailing list