Review Request: Use platform palette when running on other desktop environments

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101805/#review4278
-----------------------------------------------------------



kdeui/kernel/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/101805/#comment3506>

    So what about this call here?
    
    Will the patch still allow changing the palette of running clients? (not that i'd personally like this feature too much ;-)



kdeui/kernel/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/101805/#comment3507>

    Isn't this now a lie?
    What about the entire function ("either do nothing or emit what didn't happen anyway")


- Thomas


On June 30, 2011, 3:36 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101805/
> -----------------------------------------------------------
> 
> (Updated June 30, 2011, 3:36 p.m.)
> 
> 
> Review request for kdelibs and Olivier Goffart.
> 
> 
> Summary
> -------
> 
> When a KDE application is running on GNOME it looks odd right now because it does not use the GNOME palette, contrary to Qt-only application. Attached patch fixes this by relying on the platform plugin for the palette.
> 
> Patch was suggested by Olivier Goffart.
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.cpp 1a497c7 
> 
> Diff: http://git.reviewboard.kde.org/r/101805/diff
> 
> 
> Testing
> -------
> 
> - Run kwrite on KDE => KDE palette
> - Run kwrite on GNOME => GNOME palette
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110630/afc68810/attachment.htm>