Re: Review Request: Make “Edit File Type” button more discoverable

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101800/
-----------------------------------------------------------

(Updated June 29, 2011, 9:39 a.m.)


Review request for kdelibs.


Changes
-------

Added link to comparison screenshot privat.broulik.de/filedialogpatch.png


Summary (updated)
-------

On IRC this evening somebody found it hard to find the options to edit a specific file type. The KCM is a mess unfortunately but I told him that you could edit specific file types directly from the properties dialog.
That button is hard to spot, though, which I also often found annoying. It is neither labled nor does it stand out as “button”.
This patch solves that issue.

It is in need of discussion whether the label itself should stay but the button definitly has to look like a clickable target.

Comparison screenshot: privat.broulik.de/filedialogpatch.png (this screenshot is from the initial attempt where i forgot the capitalization :P)


Diffs
-----

  kio/kfile/kpropertiesdialog.cpp 3382daa 

Diff: http://git.reviewboard.kde.org/r/101800/diff


Testing
-------


Thanks,

Kai Uwe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110629/a0cde25a/attachment.htm>