Review Request: Fix docs generation with docbook-xslt >= 1.76

Burkhard Lück lueck at hube-lueck.de
Tue Jun 28 07:46:05 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101791/#review4225
-----------------------------------------------------------

Ship it!


Installed docbook-xsl_1.76.0~RC1+dfsg-1 and applied the patch, generated lang docs and build some modules and german language, looks ok to me. I have the missing "previous" and "next" buttons reported in http://bugs.kde.org/show_bug.cgi?id=271331.

Do we to change http://websvn.kde.org/trunk/www/areas/docs/generator for docs.kde.org?

- Burkhard


On June 27, 2011, 11:16 p.m., Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101791/
> -----------------------------------------------------------
> 
> (Updated June 27, 2011, 11:16 p.m.)
> 
> 
> Review request for kdelibs, Burkhard Lück, Rex Dieter, and Albert Astals Cid.
> 
> 
> Summary
> -------
> 
> Previously, local.l10n.xml was defined to use a build-time generated file containing the a list of languages for which we provides customizations (see kdoctools/customization/xsl). It seems that this is not the intended way for customization to work; it used to work by accident for docbook-xsl<=1.75 but the new optimaized l10n structure introduced with docbook-xsl>=1.76 broke it (see: http://lists.oasis-open.org/archives/docbook-apps/201009/msg00143.html )
>     
> The idea now is to directly load the correct customization file for the required language.
> 
> In order to fix the generated documentation, this must be regenerated again using the newly built meinproc.
> 
> 
> This addresses bug 271331.
>     http://bugs.kde.org/show_bug.cgi?id=271331
> 
> 
> Diffs
> -----
> 
>   kdoctools/CMakeLists.txt 06525c638b1a34903b9ad6f693cbde6f3e18204d 
>   kdoctools/customization/kde-include-common.xsl.cmake ad35f2000a981798fd4ef63f6719469086db2a13 
>   kdoctools/customization/kde-include-man.xsl.cmake 8727ef26d28f2fcdd7df3005d2c191de83c484b5 
>   kdoctools/customization/xsl/ca.xml fd7918596c3eaa79d58282699fa4e016263314c9 
>   kdoctools/customization/xsl/de.xml 7a965653a1588145f6175c7ccc9cbd2ed5ca496c 
>   kdoctools/customization/xsl/el.xml b1aa01f84e36f1d3b7207560e33dfc634fed31cc 
>   kdoctools/customization/xsl/en.xml 0a6f7e6d5dadba9eb0a6b6813716478dbfe47cbc 
>   kdoctools/customization/xsl/es.xml 04663f4e5b9e86b76a404676ed706436f683b76f 
>   kdoctools/customization/xsl/et.xml d764e42e6ef9a27453f1c13562dd6101b1171b35 
>   kdoctools/customization/xsl/fr.xml 15a642c1e54756cf25477b1be5257e2b1e85946a 
>   kdoctools/customization/xsl/gl.xml c13a714215bacc31b0c7ea495048b3adf78e1d28 
>   kdoctools/customization/xsl/it.xml 770b459869656b8d4bfc53719c43adcb6f9674df 
>   kdoctools/customization/xsl/lt.xml 5221d96ff9e4ab6035f515e8ec546841b5961991 
>   kdoctools/customization/xsl/nl.xml f3996ca2829f6973230d26cd2864607e835949c6 
>   kdoctools/customization/xsl/nn.xml e93a3f9bd7052db5ed4e8b4c8c6d928958870390 
>   kdoctools/customization/xsl/pl.xml a9c0922c22c625b052db7bbc07337030a62716a6 
>   kdoctools/customization/xsl/pt.xml e218846e890b1ac41797272a352d614024d6effd 
>   kdoctools/customization/xsl/pt_br.xml 9d6b96231710f28d819a78d4e2b36914e39d328b 
>   kdoctools/customization/xsl/ru.xml ff8c8424808ab9f88d00691f06ea799b6ebed839 
>   kdoctools/customization/xsl/sl.xml 058e939b983fbe1acef56396d1c1cecd9cbded39 
>   kdoctools/customization/xsl/sr.xml 3572284240d05ba4a46ea08197f059d96652793d 
>   kdoctools/customization/xsl/sv.xml af3031c7556a58999dc2454446c80ae205702a0b 
>   kdoctools/customization/xsl/tr.xml 7ceae61c3dd556a65c093fd2ef1868c33996b1a3 
>   kdoctools/customization/xsl/uk.xml 60ab441ed2984bda1b0a9f89fc2f7113af68ac8c 
>   kdoctools/docbookl10nhelper.cpp feab0478e20b1299c1951c20c6f46c25d2b570ef 
> 
> Diff: http://git.reviewboard.kde.org/r/101791/diff
> 
> 
> Testing
> -------
> 
> Testing performed on Debian testing (kdelibs 4.7, docbook-xslt 1.75/1.76) and Fedora 15 (kdelibs trunk and 4.6.4, docbook-xslt 1.75/1.76, thanks to rdieter).
> 
> 
> Thanks,
> 
> Luigi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110628/7b9f7de7/attachment.htm>


More information about the kde-core-devel mailing list