Review Request: Preffer new hunspell library over the old one in the finder

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101484/#review4076
-----------------------------------------------------------

Ship it!


Hmm, I can't see any mention of order-related preference in the help for find_library (`cmake --help-command find_library`). I suppose the right thing to do would be to ask the cmake developers to add this in the documentation, so that we can be sure it won't change in the future?

Meanwhile if you are sure of your patch, it can of course go in (do you have a kde git account?)


- David


On June 1, 2011, 11:10 a.m., Tomáš Chvátal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101484/
> -----------------------------------------------------------
> 
> (Updated June 1, 2011, 11:10 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When using FindHUNSPELL on system where both hunspell-1.2 and hunspell-1.3 are around the old version is preffered by the finder.
> 
> This patch reverts the logic so the later is preffered.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindHUNSPELL.cmake 9ed944f 
> 
> Diff: http://git.reviewboard.kde.org/r/101484/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110622/e68e3b28/attachment.htm>